Horton

Re: Separate HEAP WAL replay logic into its own file

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: "Li, Yong" <yoli@ebay.com>
Cc: Sutou Kouhei <kou@clear-code.com>, Melanie Plageman <melanieplageman@gmail.com>, "Debnath, Shawn" <sdn@ebay.com>, "Shyrabokau, Anton" <antons@ebay.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-09-11T07:41:49Z
Lists: pgsql-hackers 
On Tue, Jul 30, 2024 at 06:48:26AM +0000, Li, Yong wrote:
> Thank you Kou for your review. I will move the CF to the next
> phase and see what happens.

Quite a fan of what you are proposing here, knowing that heapam.c is
still 8.8k lines of code even after moving the 1.3k lines dedicated to
WAL records.

+#include "access/heapam_xlog.h"

This is included in heapam.h, but missing from the patch.  I guess
that you fat-fingered a `git add`.
--
Michael

Commits

  1. Move logic related to WAL replay of Heap/Heap2 into its own file