Re: Should rolpassword be toastable?
Nathan Bossart <nathandbossart@gmail.com>
From: Nathan Bossart <nathandbossart@gmail.com>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-09-19T14:22:31Z
Lists: pgsql-hackers
On Thu, Sep 19, 2024 at 06:00:00AM +0300, Alexander Lakhin wrote: > 23.09.2023 21:00, Alexander Lakhin wrote: >> So for now only pg_authid is worthy of condemnation, AFAICS. > > Let me remind you of this issue in light of b52c4fc3c. > Yes, it's opposite, but maybe it makes sense to fix it now in the hope that > ~1 year of testing will bring something helpful for both changes. Hm. It does seem like there's little point in giving pg_authid a TOAST table, as rolpassword is the only varlena column, and it obviously has problems. But wouldn't removing it just trade one unhelpful internal error when trying to log in for another when trying to add a really long password hash (which hopefully nobody is really trying to do in practice)? I wonder if we could make this a little more user-friendly. -- nathan
Commits
-
Restrict password hash length.
- 8275325a06ed 18.0 landed
-
Remove pg_authid's TOAST table.
- 6aa44060a3c9 18.0 landed
-
Remove arbitrary restrictions on password length.
- 67a472d71c98 14.0 cited