Re: Partitioned tables and [un]loggedness

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es

From: Michael Paquier <michael@paquier.xyz>

To: Nathan Bossart <nathandbossart@gmail.com>

Cc: "David G. Johnston" <david.g.johnston@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-09-10T00:42:31Z

Lists: pgsql-hackers

Attachments

v4-0001-Introduce-ATT_PARTITIONED_TABLE-in-tablecmds.c.patch (text/x-diff) patch v4-0001
v4-0002-Remove-support-for-ALTER-TABLE-.-SET-UN-LOGGED-on.patch (text/x-diff) patch v4-0002

On Mon, Sep 09, 2024 at 03:56:14PM +0900, Michael Paquier wrote:
> How about inventing a new ATT_PARTITIONED_TABLE and make a clean split
> between both relkinds?  I'd guess that blocking both SET LOGGED and
> UNLOGGED for partitioned tables is the best move, even if it is
> possible to block only one or the other, of course.

I gave it a try, and while it is much more invasive, it is also much
more consistent with the rest of the file.

Thoughts?
--
Michael

Commits

psql: Remove PARTITION BY clause in tab completion for unlogged tables
- 361499538c9d 18.0 landed
Remove support for unlogged on partitioned tables
- e2bab2d79204 18.0 landed
Remove ATT_TABLE for ALTER TABLE ... ATTACH/DETACH
- bbba59e69a56 18.0 landed
Introduce ATT_PARTITIONED_TABLE in tablecmds.c
- d69a3f4d70b7 18.0 landed
Refactor some code for ALTER TABLE SET LOGGED/UNLOGGED in tablecmds.c
- 9f87da1cffda 18.0 landed
Remove tab completion for CREATE UNLOGGED MATERIALIZED VIEW.
- 5c1ce1bbbe5f 18.0 cited