Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. injection_points: Add stats for point caching and loading

  2. injection_points: Add some fixed-numbered statistics

  1. Injection Points remaining stats

    Yogesh Sharma <yogesh.sharma@catprosystems.com> — 2024-08-12T14:25:13Z

    Hi all,

Attaching a patch to add remaining cached and loaded stats as mentioned 
in commit f68cd847fa40ead44a786b9c34aff9ccc048004b message. Existing TAP 
tests were updated to handle new stats. This patch has been tested on 
HEAD using "make check-world" after enabling injection points via 
"--enable-injection-points".

-- 
Kind Regards,
Yogesh Sharma

  2. Re: Injection Points remaining stats

    Michael Paquier <michael@paquier.xyz> — 2024-08-19T00:09:34Z

    On Mon, Aug 12, 2024 at 10:25:13AM -0400, Yogesh Sharma wrote:
> Attaching a patch to add remaining cached and loaded stats as mentioned in
> commit f68cd847fa40ead44a786b9c34aff9ccc048004b message. Existing TAP tests
> were updated to handle new stats. This patch has been tested on HEAD using
> "make check-world" after enabling injection points via
> "--enable-injection-points".

Thanks a lot for the patch.  I should have tackled that in
f68cd847fa40 but I've just lacked a combination of time and energy
while the original commit was already enough.

The code indentation was a bit incorrect, and I think that we should
also have tests to stress that the insertion of the new stats is
correct.  I have fixed the indentation, added some tests and improved
a couple of surrounding descriptions while on it.

I'm tempted to propose a separate improvement for the template of the
fixed-numbered stats.  We could do like pgstatfuncs.c where we use a
macro to define the routines of the counters, and have one function
for each counter incremented.  That's a separate refactoring, so I'll
propose that on a different thread.
--
Michael

  3. Re: Injection Points remaining stats

    Yogesh Sharma <yogesh.sharma@catprosystems.com> — 2024-08-22T17:16:37Z

    On 8/18/24 20:09, Michael Paquier wrote:
> f68cd847fa40 but I've just lacked a combination of time and energy
> while the original commit was already enough.
>
> The code indentation was a bit incorrect, and I think that we should
> also have tests to stress that the insertion of the new stats is
> correct.  I have fixed the indentation, added some tests and improved
> a couple of surrounding descriptions while on it.

Thank you for committing. I was thinking to add such test in next patch 
set. I have a updated .vimrc to have correct indentation.

> I'm tempted to propose a separate improvement for the template of the
> fixed-numbered stats.  We could do like pgstatfuncs.c where we use a
> macro to define the routines of the counters, and have one function
> for each counter incremented.  That's a separate refactoring, so I'll
> propose that on a different thread.
I will take a look on this.

-- 
Kind Regards,
Yogesh Sharma
PostgreSQL, Linux, and Networking
Open Source Enthusiast and Advocate
PostgreSQL Contributors Team @ RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

  4. Re: Injection Points remaining stats

    Michael Paquier <michael@paquier.xyz> — 2024-08-23T00:18:09Z

    On Thu, Aug 22, 2024 at 01:16:37PM -0400, Yogesh Sharma wrote:
> On 8/18/24 20:09, Michael Paquier wrote:
>> I'm tempted to propose a separate improvement for the template of the
>> fixed-numbered stats.  We could do like pgstatfuncs.c where we use a
>> macro to define the routines of the counters, and have one function
>> for each counter incremented.  That's a separate refactoring, so I'll
>> propose that on a different thread.
>
> I will take a look on this.

Thanks.  If you are interested, here is the CF entry I have created
for it:
https://commitfest.postgresql.org/49/5187/
--
Michael