Horton

Re: Removing log_cnt from pg_sequence_read_tuple()

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-08-29T01:28:03Z
Lists: pgsql-hackers 
On Thu, Aug 29, 2024 at 08:00:52AM +0900, Michael Paquier wrote:
> On Mon, Aug 26, 2024 at 09:19:06AM -0500, Nathan Bossart wrote:
>> The patch looks reasonable to me.  Do you think the name of the function
>> still makes sense now that 1) we might have different sequence AMs in the
>> near future and 2) it no longer returns everything in the sequence tuple?
> 
> Indeed, pg_sequence_read_tuple() would not reflect the reality, some
> ideas: 
> - pg_sequence_read_data
> - pg_sequence_get_data
> - pg_sequence_data
> - More consistent with other catalog functions: pg_get_sequence_data,
> as we have already in the tree a lot of pg_get_* functions.

pg_get_sequence_data() sounds fine to me.

-- 
nathan

Commits

  1. Rename pg_sequence_read_tuple() to pg_get_sequence_data()