Horton

Re: define PG_REPLSLOT_DIR

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-hackers@lists.postgresql.org
Date: 2024-08-20T08:47:57Z
Lists: pgsql-hackers 
On Mon, Aug 19, 2024 at 02:11:55PM +0000, Bertrand Drouvot wrote:
> I made the changes for pg_tblspc in pg_combinebackup.c as the number of occurences
> are greater that the "pg_wal" ones and we were to define PG_TBLSPC_DIR in any
> case.
> 
> Please find attached the related patches.

No real objection about the replslot and pg_logical bits.

- *            $PGDATA/pg_tblspc/spcoid/PG_MAJORVER_CATVER/dboid/relfilenumber
+ *            $PGDATA/PG_TBLSPC_DIR/spcoid/PG_MAJORVER_CATVER/dboid/relfilenumber

For the tablespace parts, I am not sure that I would update the
comments to reflect the variables, TBH.  Somebody reading the comments
would need to refer back to pg_tblspc/ in the header.
--
Michael

Commits

  1. Define PG_TBLSPC_DIR for path pg_tblspc/ in data folder

  2. Define PG_LOGICAL_DIR for path pg_logical/ in data folder

  3. Define PG_REPLSLOT_DIR for path pg_replslot/ in data folder