Re: Enable data checksums by default

Nathan Bossart <nathandbossart@gmail.com>

From: Nathan Bossart <nathandbossart@gmail.com>

To: Bruce Momjian <bruce@momjian.us>

Cc: Peter Eisentraut <peter@eisentraut.org>, Greg Sabino Mullane <htamfids@gmail.com>, Michael Paquier <michael@paquier.xyz>, Michael Banck <mbanck@gmx.net>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-08-26T19:46:39Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Avoid BufferGetLSNAtomic() calls during nbtree scans.
- e6eed40e4441 18.0 cited
doc PG 18 relnotes: Add incompatibility note about checksums now default
- 48814415d5aa 18.0 landed
Fix pg_upgrade's cross-version tests when old < 18
- 38c18710b37a 18.0 landed
initdb: Change default to using data checksums.
- 04bec894a04c 18.0 landed
Allow TAP tests to force checksums off when calling init()
- e7d0cf42b1ac 18.0 landed
initdb: Add new option "--no-data-checksums"
- 983a588e0b86 18.0 landed
Tweak docs to reduce possible impact of data checksums
- efd72a3d422b 18.0 landed

In general, +1 for $SUBJECT.

     printf(_("  -k, --data-checksums      use data page checksums\n"));
+    printf(_("      --no-data-checksums   do not use data page checksums\n"));

Should we error if both --data-checksum and --no-data-checksums are
specified?  IIUC with 0001, we'll use whichever is specified last.

nitpick: these 4 patches are small enough that they could likely be
combined and committed together.

I think it's fair to say we should make the pg_upgrade experience nicer
once the default changes, but IMHO that needn't block actually changing the
default.

-- 
nathan