Re: [PATCH] Add crc32(text) & crc32(bytea)

On Thu, Aug 08, 2024 at 10:49:42AM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> On Thu, Aug 08, 2024 at 04:27:20PM +0200, Peter Eisentraut wrote:
>>> The correct return type of a CRC operation in general is some kind of exact
>>> numerical type.  Just pick the best one that fits the result.  I don't think
>>> bytea is appropriate.
> 
>> That would leave us either "integer" or "bigint".  "integer" is more
>> correct from a size perspective, but will result in negative values because
>> it is signed.  "bigint" uses twice as many bytes but won't display any CRC
>> values as negative.
> 
> bigint seems fine to me; we have used that in other places as a
> substitute for uint32, eg block numbers in contrib/pageinspect.

WFM.  Here is what I have staged for commit.

-- 
nathan