Re: Flush pgstats file during checkpoints

Hi,

On Tue, Jul 30, 2024 at 03:25:31PM +0900, Michael Paquier wrote:
> On Mon, Jul 29, 2024 at 04:46:17AM +0000, Bertrand Drouvot wrote:
> > Thanks! 0001 attached is v4-0001-Revert-Test-that-vacuum-removes-tuples-older-than.patch
> > so I guess you did not attached the right one.
> 
> I did attach the right set of patches, please ignore 0001 entirely:
> the patch series is made of three patches, beginning with 0002 :)

Yeah, saw that ;-)

> > Looking at 0002:
> >
> >    if (!read_chunk(fpin, ptr, info->shared_data_len))
> > +  {
> > +		elog(WARNING, "could not read data of stats kind %d for entry of type %c",
> > +    			kind, t);
> > 
> > Nit: what about to include the "info->shared_data_len" value in the WARNING?
> 
> Good idea, so added.

Thanks!

> > Looking at 0003: LGTM
> > Looking at 0004: LGTM
> 
> Thanks.  Attached are the two remaining patches, for now.  I'm
> planning to get back to these in a few days.

Did a quick check and still LGTM.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com