Horton

Re: CREATE MATERIALIZED VIEW

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: px shi <spxlyy123@gmail.com>, pgsql-hackers@postgresql.org
Date: 2024-07-25T14:54:01Z
Lists: pgsql-hackers 
On Thu, Jul 25, 2024 at 03:49:02PM +0100, Dagfinn Ilmari Mannsåker wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> However, since it looks like the feature was never actually supported in a
>> release, and the revert has been in place for over a decade, I think it'd
>> be reasonable to remove the tab completion now.  It looks like the folks on
>> the 2021 thread felt similarly.
> 
> Keeping it in the grammar makes sense for the more specific error
> message, but I don't think the tab completion should be suggesting bogus
> things, regardless of whether it's the grammar or the parse analysis
> that rejects it.

Would you mind creating a commitfest entry for this one?  I'll plan on
committing this early next week unless any objections materialize.

-- 
nathan

Commits

  1. Remove tab completion for CREATE UNLOGGED MATERIALIZED VIEW.

  2. Add tab completion for CREATE SCHEMA in psql

  3. Disallow unlogged materialized views.

  4. Add a materialized view relations.