Re: Pluggable cumulative statistics

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es

From: Michael Paquier <michael@paquier.xyz>

To: Dmitry Dolgov <9erthalion6@gmail.com>

Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-08-01T20:53:31Z

Lists: pgsql-hackers

Attachments

v3-0001-Introduce-pluggable-APIs-for-Cumulative-Statistic.patch (text/x-diff) patch v3-0001
v3-0002-Add-helper-routines-to-retrieve-custom-data-for-f.patch (text/x-diff) patch v3-0002
v3-0003-doc-Add-section-for-Custom-Cumulative-Statistics-.patch (text/x-diff) patch v3-0003
v3-0004-injection_points-Add-statistics-for-custom-points.patch (text/x-diff) patch v3-0004
v3-0005-injection_points-Add-example-for-fixed-numbered-s.patch (text/x-diff) patch v3-0005

On Sun, Jul 28, 2024 at 10:03:56PM +0200, Dmitry Dolgov wrote:
> So far I've got nothing against :)

I've looked again at the first patch of this series, and applied the
first one.  Another last-minute edit I have done is to use more
consistently PgStat_Kind in the loops for the stats kinds across all
the pgstats code.

Attached is a rebased set of the rest, with 0001 now introducing the
pluggable core part.
--
Michael

Commits

injection_points: Add some fixed-numbered statistics
- f68cd847fa40 18.0 landed
injection_points: Add some cumulative stats for injection points
- 75534436a477 18.0 landed
Add helper routines to retrieve data for custom fixed-numbered pgstats
- 2eff9e678d35 18.0 landed
Introduce pluggable APIs for Cumulative Statistics
- 7949d9594582 18.0 landed
Switch PgStat_Kind from an enum to a uint32 type
- 3188a4582a8c 18.0 landed
Improve comment of pgstat_read_statsfile()
- 72c0b24b2ddd 18.0 landed
Add a new 'F' entry type for fixed-numbered stats in pgstats file
- 9e4664d950c1 18.0 landed
Add PgStat_KindInfo.init_shmem_cb
- 21471f18e9d9 18.0 landed
Use pgstat_kind_infos to write fixed shared statistics
- b68b29bc8fec 18.0 landed
Replace hardcoded identifiers of pgstats file by #defines
- 9fd02525793f 18.0 landed