Re: RFC: pg_stat_logmsg
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Joe Conway <mail@joeconway.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>, Gurjeet Singh <gurjeet@singh.im>, Masahiko Sawada <sawada.mshk@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-07-18T04:26:29Z
Lists: pgsql-hackers
On Wed, Jul 17, 2024 at 07:48:15AM -0400, Joe Conway wrote: > I think including version in the key makes most sense. Also do we even have > a mechanism to grab the commit sha in running code? Not directly, still that's doable. The closest thing I would consider here is to get the output of something like 'git rev-parse --short HEAD` and attach it to PG_VERSION with --with-extra-version. I do that in my local builds because I always want to know from which commit I am building something. Then, PG_VERSION could be stored with the entries while hashing the stats key with the version string, the error code, the source file name and/or the line number for uniqueness. 32 bytes of room would be most likely enough when it comes to the PG_VERSION data stored in the stats entries. -- Michael