Re: Allow non-superuser to cancel superuser tasks.
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Kirill Reshke <reshkekirill@gmail.com>, "Leung, Anthony" <antholeu@amazon.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2024-07-16T01:14:42Z
Lists: pgsql-hackers
On Mon, Jul 15, 2024 at 09:54:43AM +0900, Michael Paquier wrote: > Thanks. I'll see about stressing the buildfarm tomorrow or so, after > looking at how the CI reacts. There were a few more things here: 1) The new test was missing from test_misc/meson.build. 2) With 1) fixed, the CI has been complaining about the test stability, when retrieving the PID of a worker with this query: SELECT pid FROM pg_stat_activity WHERE backend_type = 'autovacuum worker' And it's annoying to have missed what's wrong here: - We don't check that the PID comes from a worker waiting on an injection point, so it could be a PID of something running, still gone once the signals are processed. - No limit check, so we could finish with a list of PIDs while only one is necessary. Windows was slow enough to spot that, spawning multiple autovacuum workers waiting on the injection point. After improving all that, I have checked again the CI and it was happy, so applied on HEAD. Let's see now how the buildfarm reacts. -- Michael
Commits
-
Look up backend type in pg_signal_backend() more cheaply.
- 61171a632d10 18.0 landed
-
Add tap test for pg_signal_autovacuum role
- d2b74882cab8 18.0 landed
-
Introduce pg_signal_autovacuum_worker.
- ccd38024bc3c 18.0 landed
-
Add a slot synchronization function.
- ddd5f4f54a02 17.0 cited
-
Ban role pg_signal_backend from more superuser backend types.
- 3a9b18b30953 17.0 cited