Horton

Re: relfrozenxid may disagree with row XIDs after 1ccc1e05ae

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Noah Misch <noah@leadboat.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>, Bowen Shi <zxwsbg12138@gmail.com>, Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Matthias van de Meent <boekewurm+postgres@gmail.com>, Peter Geoghegan <pg@bowt.ie>, Alexander Lakhin <exclusion@gmail.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2024-07-12T01:20:56Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Ensure vacuum removes all visibly dead tuples older than OldestXmin

  2. Combine freezing and pruning steps in VACUUM

  3. Handle non-chain tuples outside of heap_prune_chain()

  4. Fix false reports in pg_visibility

  5. Remove retry loop in heap_page_prune().

  6. vacuumlazy.c: document vistest and OldestXmin.

  7. Deduplicate choice of horizon for a relation procarray.c.

  8. Remove tupgone special case from vacuumlazy.c.

  9. Simplify state managed by VACUUM.

  10. Recycle nbtree pages deleted during same VACUUM.

  11. snapshot scalability: Don't compute global horizons while building snapshots.

  12. Raise error when affecting tuple moved into different partition.

On Thu, Jul 11, 2024 at 02:16:08PM -0700, Noah Misch wrote:
> On Mon, Jul 08, 2024 at 05:23:52PM -0400, Melanie Plageman wrote:
>> I am nervous about the test flaking on the buildfarm. But I did
>> the best I could to try to make it stable. I think keeping it as a
>> separate commit should be easiest in case we have to revert it?
> 
> Whether one uses a separate commit or not, it's easy to remove a new test.  I
> think either way is fine.  We've not typically committed tests separately.

Depends.  Melanie, if you are nervous about the test stability, I'd
suggest to do what you think is better and separate that into two
commits to ease your flow, then.  This will limit the damage should a
revert of the test be done.  I'm pretty sure that I have done that in
the past more than once when I had similar concerns in mind.
--
Michael