Re: Fix an incorrect assertion condition in mdwritev().

Michael Paquier <michael@paquier.xyz>

View thread

From: Michael Paquier <michael@paquier.xyz>

To: Andres Freund <andres@anarazel.de>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Xing Guo <higuoxing@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2024-06-05T04:10:41Z

Lists: pgsql-hackers

Attachments

assert_mdwritev.patch (text/x-diff) patch

On Mon, Jun 03, 2024 at 03:24:07PM -0700, Andres Freund wrote:
> I'm confused - isn't using common/int.h entirely sufficient for that? Nearly
> all architectures have more efficient ways to check for 64bit overflows than
> doing actual 128 bit math.

One simple way to change the assertion would be something like that, I
assume.  Andres, does it answer your concerns?
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Improve assertion in mdwritev()
- f04d1c1db011 17.0 landed
Provide vectored variants of smgrread() and smgrwrite().
- 4908c5872059 17.0 cited