Re: pg_parse_json() should not leak token copies on failure
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@postgresql.org
Date: 2024-06-05T05:15:20Z
Lists: pgsql-hackers
On Tue, Jun 04, 2024 at 10:10:06AM -0700, Jacob Champion wrote: > On Mon, Jun 3, 2024 at 9:32 PM Kyotaro Horiguchi > <horikyota.ntt@gmail.com> wrote: >> I understand that the part enclosed in parentheses refers to the "if >> (ptr) pfree(ptr)" structure. I believe we rely on the behavior of >> free(NULL), which safely does nothing. (I couldn't find the related >> discussion due to a timeout error on the ML search page.) > > For the frontend, right. For the backend, pfree(NULL) causes a crash. > I think [1] is a related discussion on the list, maybe the one you > were looking for? FYI, these choices relate also to 805a397db40b, e890ce7a4feb and 098c703d308f. -- Michael
Commits
-
jsonapi: add lexer option to keep token ownership
- 5c32c21afe64 18.0 landed