Re: Fix src/test/subscription/t/029_on_error.pl test when wal_debug is enabled
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Ilyasov Ian <ianilyasov@outlook.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2024-05-16T23:55:07Z
Lists: pgsql-hackers
On Thu, May 16, 2024 at 09:00:47AM +0530, Amit Kapila wrote: > This can only be a problem if the apply worker generates more LOG > entries with the required context but it won't do that unless there is > an operation on the publisher to replicate. If we see any such danger > then I agree this can break on some slow machines but as of now, I > don't see any such race condition. Perhaps, still I'm not completely sure if this assumption is going to always stand for all the possible configurations we support. So, rather than coming back to this test again, I would choose to make the test as stable as possible from the start. That's what mapping with the error message would offer when grabbing the LSN from the CONTEXT part of it, because there's a one-one mapping between the expected ERROR and its CONTEXT from which the information used by the test is retrieved. -- Michael
Commits
-
Improve stability of subscription/029_on_error.pl
- 8e16f81f3db4 15.8 landed
- 338fb8714c6c 16.4 landed
- ac8c85d04b13 17.0 landed