Re: Log details for stats dropped more than once

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2024-05-15T23:17:17Z
Lists: pgsql-hackers
On Wed, May 15, 2024 at 08:04:48AM +0000, Bertrand Drouvot wrote:
> Thanks! BTW, I just realized that adding more details for this error has already
> been mentioned in [1] (and Andres did propose a slightly different version).
> 
> [1]: https://www.postgresql.org/message-id/20240505160915.6boysum4f34siqct%40awork3.anarazel.de

Ah, it is not surprising.  I'd agree with doing what is posted there
for simplicity's sake.  Rather than putting that in a errdetail, let's
keep all the information in an errmsg() as that makes deparsing
easier, and let's keep the elog().
--
Michael

Commits

  1. Add more debugging information when dropping twice pgstats entry