Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove resowner_private.h

  2. Make ResourceOwners more easily extensible.

  1. Remove deprecated header file resowner_private.h.

    Xing Guo <higuoxing@gmail.com> — 2024-04-20T02:07:45Z

    Hi hackers,

I noticed that the header file resowner_private.h is deprecated and no
longer useful after commit b8bff07[^1]. We should remove it.

[^1]: https://github.com/postgres/postgres/commit/b8bff07daa85c837a2747b4d35cd5a27e73fb7b2

Best Regards,
Xing

  2. Re: Remove deprecated header file resowner_private.h.

    Michael Paquier <michael@paquier.xyz> — 2024-04-20T02:54:29Z

    On Sat, Apr 20, 2024 at 10:07:45AM +0800, Xing Guo wrote:
> I noticed that the header file resowner_private.h is deprecated and no
> longer useful after commit b8bff07[^1]. We should remove it.

Nice catch, looks like a `git rm` has been slippery here .  It is
indeed confusing to keep it around now that all these routines are
mostly internal or have been switched to static inline that work as
wrappers of some other resowner routines.

Will clean up.
--
Michael

  3. Re: Remove deprecated header file resowner_private.h.

    Michael Paquier <michael@paquier.xyz> — 2024-04-20T09:03:21Z

    On Sat, Apr 20, 2024 at 11:54:29AM +0900, Michael Paquier wrote:
> Will clean up.

While looking at the whole, I've noticed that this has been mentioned
here by Andres, but the committed patch did not get the call:
https://www.postgresql.org/message-id/20231117204441.7ff37sw53udg34lc@awork3.anarazel.de
--
Michael

  4. Re: Remove deprecated header file resowner_private.h.

    Xing Guo <higuoxing@gmail.com> — 2024-04-20T10:21:38Z

    On Sat, Apr 20, 2024 at 5:03 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Sat, Apr 20, 2024 at 11:54:29AM +0900, Michael Paquier wrote:
> > Will clean up.
>
> While looking at the whole, I've noticed that this has been mentioned
> here by Andres, but the committed patch did not get the call:
> https://www.postgresql.org/message-id/20231117204441.7ff37sw53udg34lc@awork3.anarazel.de

You're right. I didn't go through the original thread carefully.
Thanks for the fix.

> --
> Michael