Horton

Re: Confusing #if nesting in hmac_openssl.c

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Date: 2024-04-03T06:18:10Z
Lists: pgsql-hackers 
On Tue, Apr 02, 2024 at 03:56:13PM +0200, Daniel Gustafsson wrote:
> > On 2 Apr 2024, at 15:50, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> > I'll go ahead with what I have.
> 
> +1

+#ifdef USE_RESOWNER_FOR_HMAC 

Why not, that's cleaner.  Thanks for the commit.  The interactions
between this code and b8bff07da are interesting.
--
Michael

Commits

  1. Unwind #if spaghetti in hmac_openssl.c a bit.

  2. Refactor HMAC implementations