Horton

Re: Autogenerate some wait events code and documentation

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Noah Misch <noah@leadboat.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-04-04T10:14:47Z
Lists: pgsql-hackers 
On Thu, Apr 04, 2024 at 09:28:36AM +0000, Bertrand Drouvot wrote:
> On Thu, Apr 04, 2024 at 03:50:21PM +0900, Michael Paquier wrote:
>> Is "Backpatch" the best choice we have, though?  It speaks by itself
>> but I was thinking about something different, like "Stable".  Other
>> ideas or objections are welcome.  My naming sense is usually not that
>> good, so there's that.
> 
> I think "Stable" is more confusing because the section should also be empty until
> the .0 is released.

Okay.

> That said, what about "ABI_compatibility"? (that would also match the comment 
> added in wait_event_names.txt). Attached v4 making use of the ABI_compatibility
> proposal.

I'm OK with that.  If somebody comes up wiht a better name than that,
this could always be changed again.

> +# No "Backpatch" region here as code is generated automatically.
> 
> What about "....region here as has its own C code" (that would be more consistent
> with the comment in the "header" for the file). Done that way in v4.

I'd add a "as -this section- has its own C code", for clarity.  This
just looked a bit strange here.

> It looks like WAL_SENDER_WRITE_ZZZ was also added in it (I guess for testing
> purpose, so I removed it in v4).

That's a good brain fade.  Thanks.
--
Michael

Commits

  1. Add "ABI_compatibility" regions to wait_event_names.txt

  2. Remove column for wait event names in wait_event_names.txt

  3. Use more consistent names for wait event objects and types

  4. Add information about line contents on parsing failure of wait_event_names.txt

  5. Remove double quotes from the second column of wait_event_names.txt

  6. Generate automatically code and documentation related to wait events

  7. Refactor some code related to wait events "BufferPin" and "Extension"

  8. doc: Fix ordering of entries in wait event table for I/O type