Horton

Re: Autogenerate some wait events code and documentation

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Noah Misch <noah@leadboat.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-03-18T23:39:11Z
Lists: pgsql-hackers 
On Mon, Mar 18, 2024 at 08:49:34AM -0700, Noah Misch wrote:
> On Mon, Mar 18, 2024 at 09:04:44AM +0000, Bertrand Drouvot wrote:
>> +# Ensure that the wait events under the "Backpatch" delimiter are placed in the
>> +# same order as in the pre 17 wait_event_types.h (see VERSION_FILE_SYNC as an
>> +# example).
> 
> I expect the normal practice will be to put the entry in its natural position
> in git master, then put it in the backpatch section for any other branch.  In
> other words, the backpatch regions are always empty in git master, and the
> non-backpatch regions change in master only.

Yes, I'd expect the same experience.  And it is very important to
document that properly in the txt file.  I don't see a need to specify
any version numbers as well, that's less burden when bumping the major
version number on the master branch every year.
--
Michael

Commits

  1. Add "ABI_compatibility" regions to wait_event_names.txt

  2. Remove column for wait event names in wait_event_names.txt

  3. Use more consistent names for wait event objects and types

  4. Add information about line contents on parsing failure of wait_event_names.txt

  5. Remove double quotes from the second column of wait_event_names.txt

  6. Generate automatically code and documentation related to wait events

  7. Refactor some code related to wait events "BufferPin" and "Extension"

  8. doc: Fix ordering of entries in wait event table for I/O type