Missing LWLock protection in pgstat_reset_replslot()

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

To: pgsql-hackers@lists.postgresql.org

Date: 2024-03-01T10:15:48Z

Lists: pgsql-hackers

Attachments

v1-0001-Adding-LWLock-protection-in-pgstat_reset_replslot.patch (text/x-diff)

Hi hackers,

I think that pgstat_reset_replslot() is missing LWLock protection. Indeed, we
don't have any guarantee that the slot is active (then preventing it to be
dropped/recreated) when this function is executed.

Attached a patch to add the missing protection.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

Fix invalidation of local pgstats references for entry reinitialization
- 1df1e1e78762 15.11 landed
- ae77bcc3aa1b 16.7 landed
- dc5f9054186a 17.3 landed
- da99fedf8c17 18.0 landed
Improve consistency of replication slot statistics
- b36fbd9f8da1 17.0 landed