Re: Improve readability by using designated initializers when possible

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Japin Li <japinli@hotmail.com>

Cc: Jelte Fennema-Nio <postgres@jeltef.nl>, jian he <jian.universality@gmail.com>, Jeff Davis <pgsql@j-davis.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-hackers@lists.postgresql.org

Date: 2024-02-28T03:59:24Z

Lists: pgsql-hackers

Attachments

v6-0002-Use-designated-initializer-syntax-to-improve-read.patch (text/x-diff) patch v6-0002
v6-0003-Simplify-pg_enc2gettext_tbl.patch (text/x-diff) patch v6-0003

On Wed, Feb 28, 2024 at 09:41:42AM +0800, Japin Li wrote:
> On Wed, 28 Feb 2024 at 00:06, Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
>> Attached is v5 of the patchset that also includes this change (with
>> you listed as author).
> 
> Thanks for updating the patch!

Cool.  I have applied 0004 and most of 0002.  Attached is what
remains, where I am wondering if it would be cleaner to do these bits
together (did not look at the whole, yet).

> It looks good to me except there is an outdated comment.

Yep, I've updated that in the attached for now.
--
Michael

Commits

Remove ObjectClass type
- 89e5ef7e2181 17.0 landed
Simplify pg_enc2gettext_tbl[] with C99-designated initializer syntax
- 655dc310460c 17.0 landed
Use C99-designated initializer syntax for arrays related to encodings
- ada87a4d95fc 17.0 landed
Remove last NULL element in config_group_names[]
- 48920476b490 17.0 landed
Use C99-designated initializer syntax for more arrays
- afd8ef39094b 17.0 landed
Remove unnecessary array object_classes[] in dependency.c
- ef5e2e90859a 17.0 landed
Add trailing commas to enum definitions
- 611806cd726f 17.0 cited