Horton

Re: 039_end_of_wal: error in "xl_tot_len zero" test

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Anton Voloshin <a.voloshin@postgrespro.ru>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2024-02-15T04:28:56Z
Lists: pgsql-hackers 
On Fri, Jan 19, 2024 at 11:35:30AM +1300, Thomas Munro wrote:
> On Fri, Jan 19, 2024 at 1:47 AM Anton Voloshin
> <a.voloshin@postgrespro.ru> wrote:
>> I believe there is a small problem in the 039_end_of_wal.pl's
>> "xl_tot_len zero" test. It supposes that after immediate shutdown the
>> server, upon startup recovery, should always produce a message matching
>> "invalid record length at .*: wanted 24, got 0". However, if the
>> circumstances are just right and we happened to hit exactly on the edge
>> of WAL page, then the message on startup recovery would be "invalid
>> magic number 0000 in log segment .*, offset .*". The test does not take
>> that into account.
> 
> Thanks for figuring this out!  Right, I see.  I will look more closely
> when I'm back from summer vacation in a few days, but first reaction:

Thomas, are you planning to look at that?
--
Michael

Commits

  1. Stabilize 039_end_of_wal test.

  2. Create syscache entries for pg_extension