Horton

Re: Use of backup_label not noted in log

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgmasters.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Michael Banck <mbanck@gmx.net>, Andres Freund <andres@anarazel.de>, Pg Hackers <pgsql-hackers@postgresql.org>, Laurenz Albe <laurenz.albe@cybertec.at>
Date: 2024-01-30T00:51:01Z
Lists: pgsql-hackers 
On Mon, Jan 29, 2024 at 10:03:19AM -0400, David Steele wrote:
> I took a pass at this on PG14 and things definitely look a lot different
> back there. Not only is the timeline missing, but there are two sections of
> code for ending a backup, one for standby backup and one for primary.

Unfortunately.  The TLI from the start WAL segment lacking from these
APIs is really annoying especially if the backup_label is gone for
some reason..

> I'm satisfied with the back patches as they stand, unless anyone else wants
> to have a look.

Okay, thanks for double-checking!
--
Michael

Commits

  1. Add more LOG messages when starting and ending recovery from a backup