Horton

Re: Use of backup_label not noted in log

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgmasters.net>
Cc: Andres Freund <andres@anarazel.de>, Pg Hackers <pgsql-hackers@postgresql.org>, Laurenz Albe <laurenz.albe@cybertec.at>
Date: 2024-01-25T08:12:53Z
Lists: pgsql-hackers 
On Mon, Jan 22, 2024 at 04:36:27PM +0900, Michael Paquier wrote:
> +       if (ControlFile->backupStartPoint != InvalidXLogRecPtr)
> 
> Nit 1: I would use XLogRecPtrIsInvalid here.
> 
> +       ereport(LOG,
> +               (errmsg("completed backup recovery with redo LSN %X/%X",
> +                       LSN_FORMAT_ARGS(oldBackupStartPoint))));
> 
> Nit 2: How about adding backupEndPoint in this LOG?  That would give:
> "completed backup recovery with redo LSN %X/%X and end LSN %X/%X".

Hearing nothing, I've just applied a version of the patch with these
two modifications on HEAD.  If this needs tweaks, just let me know.
--
Michael

Commits

  1. Add more LOG messages when starting and ending recovery from a backup