Horton

Re: BUG #18240: Undefined behaviour in cash_mul_flt8() and friends

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: "Jonathan S. Katz" <jkatz@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, David Rowley <dgrowleyml@gmail.com>, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2024-01-15T07:54:51Z
Lists: pgsql-bugs 
On Sun, Jan 14, 2024 at 09:55:03AM +0900, Michael Paquier wrote:
> By the way, let me know if you have any objections about the patch I
> have posted upthread that reduces the dependency to money in the main
> regression test suite, replacing things with varbit while keeping
> coverage the same.  I have a few second thoughts about the change in
> create_table, so I'm tempted to leave that part out for now, switching
> the rest.

This one has been backpatched as 31acee4b66f9 for now, but I've left
out the test case in create_table with partitions.  I kind of felt
that I was missing something, and it did not prevent to switch all the
others.

I'll spawn a thread on -hackers about what to do next, with probably a
patch to propose a deprecation notice in the docs for v17.
--
Michael

Commits

  1. Add overflow checks to money type.

  2. Reduce dependency to money data type in main regression test suite