Re: Pluggable cumulative statistics

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es

From: Michael Paquier <michael@paquier.xyz>

To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-07-09T06:54:37Z

Lists: pgsql-hackers

Attachments

v5-0001-Add-PgStat_KindInfo.init_shmem_cb.patch (text/x-diff) patch v5-0001
v5-0002-Add-a-new-F-type-of-entry-in-pgstats-file.patch (text/x-diff) patch v5-0002
v5-0003-Switch-PgStat_Kind-from-enum-to-uint32.patch (text/x-diff) patch v5-0003
v5-0004-Introduce-pluggable-APIs-for-Cumulative-Statistic.patch (text/x-diff) patch v5-0004
v5-0005-doc-Add-section-for-Custom-Cumulative-Statistics-.patch (text/x-diff) patch v5-0005
v5-0006-injection_points-Add-statistics-for-custom-points.patch (text/x-diff) patch v5-0006
v5-0007-injection_points-Add-example-for-fixed-numbered-s.patch (text/x-diff) patch v5-0007

On Mon, Jul 08, 2024 at 02:07:58PM +0000, Bertrand Drouvot wrote:
> It looks pretty straightforward, just one comment:
> 
> +                       ptr = ((char *) ctl) + kind_info->shared_ctl_off;
> +                       kind_info->init_shmem_cb((void *) ptr);
> 
> I don't think we need to cast ptr to void when calling init_shmem_cb(). Looking
> at some examples in the code, it does not look like we cast the argument to void
> when a function has (void *) as parameter (also there is examples in 0003 where
> it's not done, see next comments for 0003).

Yep.  Fine by me.

Please find attached a rebased patch set for now, to make the
CF bot happy.
--
Michael

Commits

injection_points: Add some fixed-numbered statistics
- f68cd847fa40 18.0 landed
injection_points: Add some cumulative stats for injection points
- 75534436a477 18.0 landed
Add helper routines to retrieve data for custom fixed-numbered pgstats
- 2eff9e678d35 18.0 landed
Introduce pluggable APIs for Cumulative Statistics
- 7949d9594582 18.0 landed
Switch PgStat_Kind from an enum to a uint32 type
- 3188a4582a8c 18.0 landed
Improve comment of pgstat_read_statsfile()
- 72c0b24b2ddd 18.0 landed
Add a new 'F' entry type for fixed-numbered stats in pgstats file
- 9e4664d950c1 18.0 landed
Add PgStat_KindInfo.init_shmem_cb
- 21471f18e9d9 18.0 landed
Use pgstat_kind_infos to write fixed shared statistics
- b68b29bc8fec 18.0 landed
Replace hardcoded identifiers of pgstats file by #defines
- 9fd02525793f 18.0 landed