Re: BUG #18499: Reindexing spgist index concurrently triggers Assert("TransactionIdIsValid(state->myXid)")

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2024-06-21T01:54:09Z
Lists: pgsql-bugs
On Sun, Jun 16, 2024 at 07:30:46PM -0400, Tom Lane wrote:
> Right.  I was thinking that CIC wouldn't reach spginsert(), rather
> spgbuild(), but it does feel a bit rickety.  A separate flag would
> be better.

Why does it feel rickety for you?  We already rely on this flag so it
does not seem like a huge problem to rely on it again for the sake of
this index AM.
--
Michael

Commits

  1. Fix insertion of SP-GiST REDIRECT tuples during REINDEX CONCURRENTLY.