Horton

Thread

Commits

  1. Fix comment in pg_upgrade.h.

  2. Add pg_upgrade to /contrib; will be in 9.0 beta2.

  1. fix pg_upgrade comment

    Nathan Bossart <nathandbossart@gmail.com> — 2024-06-18T19:50:05Z

    I noticed that the "check" variable, which is used for "pg_upgrade
--check", is commented as follows:

	bool		check;			/* true -> ask user for permission to make
								 * changes */

This comment was first added when pg_upgrade was introduced (commit
c2e9b2f288), but I imagine it predates even that.  I've attached a patch to
fix this.  Barring objections, I'll probably commit this soon.

-- 
nathan

  2. Re: fix pg_upgrade comment

    Daniel Gustafsson <daniel@yesql.se> — 2024-06-18T20:20:06Z

    > On 18 Jun 2024, at 21:50, Nathan Bossart <nathandbossart@gmail.com> wrote:
> 
> I noticed that the "check" variable, which is used for "pg_upgrade
> --check", is commented as follows:
> 
> bool check; /* true -> ask user for permission to make
> * changes */
> 
> This comment was first added when pg_upgrade was introduced (commit
> c2e9b2f288), but I imagine it predates even that.  I've attached a patch to
> fix this.  Barring objections, I'll probably commit this soon.

Nice catch, +1 for committing. 

--
Daniel Gustafsson

  3. Re: fix pg_upgrade comment

    Nathan Bossart <nathandbossart@gmail.com> — 2024-06-19T21:14:10Z

    On Tue, Jun 18, 2024 at 10:20:06PM +0200, Daniel Gustafsson wrote:
> Nice catch, +1 for committing. 

Committed.

-- 
nathan