small pg_dump code cleanup
Nathan Bossart <nathandbossart@gmail.com>
From: Nathan Bossart <nathandbossart@gmail.com>
To: pgsql-hackers@postgresql.org
Date: 2024-06-05T15:13:57Z
Lists: pgsql-hackers
Attachments
- v1-0001-Trim-some-unnecessary-pg_dump-code.patch (text/plain)
While reviewing Daniel's pg_dump patch [0], I was initially confused because the return value of getTypes() isn't saved anywhere. Once I found commit 92316a4, I realized that data was actually stored in a separate hash table. In fact, many of the functions in this area don't actually need to return anything, so we can trim some code and hopefully reduce confusion a bit. Patch attached. [0] https://postgr.es/m/8F1F1E1D-D17B-4B33-B014-EDBCD15F3F0B%40yesql.se -- nathan
Commits
-
pg_dump: Remove some unused return values.
- 8213df9effaf 18.0 landed
-
In pg_dump, use simplehash.h to look up dumpable objects by OID.
- 92316a4582a5 15.0 cited