Horton

Re: BUG #18259: Assertion in ExtendBufferedRelLocal() fails after no-space-left condition

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: tender wang <tndrwang@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>, Alexander Lakhin <exclusion@gmail.com>, pgsql-bugs@lists.postgresql.org, Andres Freund <andres@anarazel.de>
Date: 2024-01-04T00:40:56Z
Lists: pgsql-bugs 
On Wed, Jan 03, 2024 at 02:46:06PM +0800, tender wang wrote:
> We had better add more comments to eplain when enter if(found) {...}
> branch, and when enter the ‘else {...}'  branch in
> ExtendBufferedRelLocal().

Like?  I don't feel like there is a need for more documentation in
this area, but of course feel free to add anything you think would be
worth adding, either as a patch or as suggestions for such comments
for these specific code path branches.
--
Michael

Commits

  1. Fix corruption of local buffer state during extend of temp relation

  2. bufmgr: Acquire and clean victim buffer separately