Re: Build versionless .so for Android
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Matthias Kuhn <matthias@opengis.ch>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-12-31T06:24:27Z
Lists: pgsql-hackers
On Sun, Dec 31, 2023 at 06:08:04AM +0100, Matthias Kuhn wrote: > In order to ship libpq on Android, it needs to be built without a version > suffix on the .so file. > The attached patch will make sure that no version is added when built for > Android. FWIW, I have mixed feelings about patching the code to treat android-linux as an exception while changing nothing in the documentation to explain why this is required. A custom patch may serve you better here, and note that you did not even touch the meson paths. See libpq_c_args in src/interfaces/libpq/meson.build as one example. That's just my opinion, of course, still there are no buildfarm members that would cover your patch. > I was wondering if there are a) any comments on the approach and if I > should be handed in for a commitfest (currently waiting for the cooldown > period after account activation, I am not sure how long that is) Such discussions are adapted in a commit fest entry. No idea if there is a cooldown period after account creation before being able to touch the CF app contents, though. -- Michael
Commits
-
Support shared libraries on Android (using make)
- 79b03dbb3304 17.0 landed
-
meson: Map host_system android to linux
- f4447af5b1a6 17.0 landed
-
meson: portname was set too early
- 4b4b3467ee36 17.0 landed
- 8b31b689f4db 16.2 landed