Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix documentation for wal_summary_keep_time.

  1. Wrong datatype in docs for wal_summary_keep_time

    hubert depesz lubaczewski <depesz@depesz.com> — 2024-01-08T16:37:14Z

    Hi,
I was reviewing new changes, and found out that we now have
"wal_summary_keep_time" setting, but the docs
(https://www.postgresql.org/docs/devel/runtime-config-wal.html#RUNTIME-CONFIG-WAL-SUMMARIZATION)
say that it's boolean, while it is integer.

The fix is simple:

#v+
--- config.sgml 2024-01-05 10:43:17.776276803 +0100
+++ config.sgml.fixed   2024-01-08 17:35:54.202968175 +0100
@@ -4179,7 +4179,7 @@
      </varlistentry>

      <varlistentry id="guc-wal-summary-keep-time" xreflabel="wal_summary_keep_time">
-      <term><varname>wal_summary_keep_time</varname> (<type>boolean</type>)
+      <term><varname>wal_summary_keep_time</varname> (<type>integer</type>)
       <indexterm>
        <primary><varname>wal_summary_keep_time</varname> configuration parameter</primary>
       </indexterm>
#v-

Best regards,

depesz

  2. Re: Wrong datatype in docs for wal_summary_keep_time

    Nathan Bossart <nathandbossart@gmail.com> — 2024-01-08T23:23:11Z

    On Mon, Jan 08, 2024 at 05:37:14PM +0100, hubert depesz lubaczewski wrote:
> I was reviewing new changes, and found out that we now have
> "wal_summary_keep_time" setting, but the docs
> (https://www.postgresql.org/docs/devel/runtime-config-wal.html#RUNTIME-CONFIG-WAL-SUMMARIZATION)
> say that it's boolean, while it is integer.

Indeed.  I'll try to get this committed tonight unless Robert beats me to
it.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

  3. Re: Wrong datatype in docs for wal_summary_keep_time

    Nathan Bossart <nathandbossart@gmail.com> — 2024-01-09T03:47:22Z

    On Mon, Jan 08, 2024 at 05:23:11PM -0600, Nathan Bossart wrote:
> On Mon, Jan 08, 2024 at 05:37:14PM +0100, hubert depesz lubaczewski wrote:
>> I was reviewing new changes, and found out that we now have
>> "wal_summary_keep_time" setting, but the docs
>> (https://www.postgresql.org/docs/devel/runtime-config-wal.html#RUNTIME-CONFIG-WAL-SUMMARIZATION)
>> say that it's boolean, while it is integer.
> 
> Indeed.  I'll try to get this committed tonight unless Robert beats me to
> it.

I noticed that the docs also fail to mention how the value of this
parameter is interpreted when specified without units, so I've put together
a v2 patch that fixes this, too.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

  4. Re: Wrong datatype in docs for wal_summary_keep_time

    Nathan Bossart <nathandbossart@gmail.com> — 2024-01-09T17:38:27Z

    On Mon, Jan 08, 2024 at 09:47:22PM -0600, Nathan Bossart wrote:
> I noticed that the docs also fail to mention how the value of this
> parameter is interpreted when specified without units, so I've put together
> a v2 patch that fixes this, too.

And committed.  Thanks for the report!

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com