Horton

Re: verify predefined LWLocks have entries in wait_event_names.txt

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread View on postgr.es
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Michael Paquier <michael@paquier.xyz>
Date: 2024-01-08T07:59:10Z
Lists: pgsql-hackers 
Hi,

On Sat, Jan 06, 2024 at 10:18:52AM -0600, Nathan Bossart wrote:
> On Sat, Jan 06, 2024 at 09:03:52AM +0000, Bertrand Drouvot wrote:
> > Sorry, I missed this in my first review, but instead of:
> > 
> > -  input: files('../../backend/storage/lmgr/lwlocknames.txt'),
> > +  input: [files('../../backend/storage/lmgr/lwlocknames.txt'), files('../../backend/utils/activity/wait_event_names.txt')],
> > 
> > what about?
> > 
> >   input: files(
> >     '../../backend/storage/lmgr/lwlocknames.txt',
> >     '../../backend/utils/activity/wait_event_names.txt',
> >   ),
> > 
> > It's done that way in doc/src/sgml/meson.build for example.
> 
> I fixed this in v4.

Thanks!

+  input: [files(
+    '../../backend/storage/lmgr/lwlocknames.txt',
+    '../../backend/utils/activity/wait_event_names.txt')],

I think the "[" and "]" are not needed here.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

  1. Cross-check lists of predefined LWLocks.

  2. Remove Lock suffix from WALSummarizerLock in wait_event_names.txt

  3. Drop the redundant "Lock" suffix from LWLock wait event names.