Horton

Re: Remove MSVC scripts from the tree

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: vignesh C <vignesh21@gmail.com>, Shubham Khanna <khannashubham1197@gmail.com>, Andres Freund <andres@anarazel.de>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-12-20T01:14:55Z
Lists: pgsql-hackers 
On Tue, Dec 19, 2023 at 04:24:02PM +0100, Peter Eisentraut wrote:
> Here are patches for these two issues.  More testing would be appreciated.
>
> --- a/contrib/basebackup_to_shell/meson.build
> +++ b/contrib/basebackup_to_shell/meson.build
> @@ -24,7 +24,7 @@ tests += {
>      'tests': [
>        't/001_basic.pl',
>      ],
> -    'env': {'GZIP_PROGRAM': gzip.path(),
> -            'TAR': tar.path()},
> +    'env': {'GZIP_PROGRAM': gzip.found() ? gzip.path() : '',
> +            'TAR': tar.found() ? tar.path() : '' },
>    },

Hmm.  Interesting.  So this basically comes down to the fact that GZIP
and TAR are required in ./configure because distcheck has a hard
dependency on both, but we don't support this target in meson.  Is
that right?
--
Michael

Commits

  1. Make win32tzlist.pl checkable again

  2. meson: Make gzip and tar optional

  3. meson: Make sed optional

  4. Remove MSVC scripts

  5. Replace Gen_dummy_probes.sed with Gen_dummy_probes.pl