Re: introduce dynamic shared memory registry

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Andrei Lepikhov <a.lepikhov@postgrespro.ru>, pgsql-hackers@postgresql.org
Date: 2023-12-20T00:04:00Z
Lists: pgsql-hackers
On Tue, Dec 19, 2023 at 10:14:44AM -0600, Nathan Bossart wrote:
> On Tue, Dec 19, 2023 at 10:49:23AM -0500, Robert Haas wrote:
>> On Mon, Dec 18, 2023 at 3:32 AM Andrei Lepikhov
>> <a.lepikhov@postgrespro.ru> wrote:
>>> 2. I think a separate file for this feature looks too expensive.
>>> According to the gist of that code, it is a part of the DSA module.
>> 
>> -1. I think this is a totally different thing than DSA. More files
>> aren't nearly as expensive as the confusion that comes from smushing
>> unrelated things together.
> 
> Agreed.  I think there's a decent chance that more functionality will be
> added to this registry down the line, in which case it will be even more
> important that this stuff stays separate from the tools it is built with.

+1 for keeping a clean separation between both.
--
Michael

Commits

  1. Fix possible NULL pointer dereference in GetNamedDSMSegment().

  2. Teach autoprewarm to use the dynamic shared memory registry.

  3. Introduce the dynamic shared memory registry.

  4. doc: Reorganize section for shared memory and LWLocks.