Re: BUG #18246: pgstathashindex() attempts to read invalid file for hash index attached to partitioned table

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2023-12-13T14:18:14Z
Lists: pgsql-bugs
On Wed, Dec 13, 2023 at 09:00:01AM +0000, PG Bug reporting form wrote:
> This anomaly can be observed since 8b08f7d48 from 2018-01-19, but IMO the
> culprit is e759854a0 from 2017-02-03, which introduced the following
> asymmetry in pgstatindex.c:
> if (!IS_INDEX(rel) || !IS_BTREE(rel))
> if (!IS_INDEX(rel) || !IS_GIN(rel))
> But:
> if (!IS_HASH(rel))

Fun, let's fix that.  Would you like to write a patch?
--
Michael

Commits

  1. pageinspect: Fix failure with hash_bitmap_info() for partitioned indexes

  2. pgstattuple: Fix failure with pgstathashindex() for partitioned indexes

  3. Don't try to open visibilitymap when analyzing a foreign table