Horton

Re: SSL tests fail on OpenSSL v3.2.0

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Tristan Partin <tristan@neon.tech>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>, Andres Freund <andres@anarazel.de>, Bo Anderson <mail@boanderson.me>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-11-27T23:53:45Z
Lists: pgsql-hackers 
On Mon, Nov 27, 2023 at 12:33:49PM -0600, Tristan Partin wrote:
> -		res = secure_raw_read(((Port *) BIO_get_data(h)), buf, size);
> +		res = secure_raw_read(((Port *) BIO_get_app_data(h)), buf, size);
>  		BIO_clear_retry_flags(h);
>  		if (res <= 0)

Interesting.  I have yet to look at that in details, but
BIO_get_app_data() exists down to 0.9.8, which is the oldest version
we need to support for stable branches.  So that looks like a safe
bet.

> -#ifndef HAVE_BIO_GET_DATA
> -#define BIO_get_data(bio) (bio->ptr)
> -#define BIO_set_data(bio, data) (bio->ptr = data)
> -#endif

Shouldn't this patch do a refresh of configure.ac and remove the check
on BIO_get_data() if HAVE_BIO_GET_DATA is gone?
--
Michael

Commits

  1. Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.