Thread

1. patch: change magic constants to DEFINE value for readability.

   DaeMyung Kang <charsyam@gmail.com> — 2015-05-23T02:40:36Z

   in src/backend/utils/misc/tzparser.c
   
   It uses 60 * 60 to represent SECS_PER_HOUR.
   
   and It is already define in other files.
   
   so I think using SECS_PER_HOUR is more clear for readability.
   
   and I attached patch.(it just change 60 * 60 to SECS_PER_HOUR)
   
   What do you think?
   

2. Re: [HACKERS] patch: change magic constants to DEFINE value for readability.

   Bruce Momjian <bruce@momjian.us> — 2023-11-25T03:36:55Z

   On Sat, May 23, 2015 at 11:40:36AM +0900, CharSyam wrote:
   > in src/backend/utils/misc/tzparser.c
   > 
   > It uses 60 * 60 to represent SECS_PER_HOUR.
   > 
   > and It is already define in other files.
   > 
   > so I think using SECS_PER_HOUR is more clear for readability.
   > 
   > and I attached patch.(it just change 60 * 60 to SECS_PER_HOUR)
   > 
   > What do you think?
   
   Yes, this patch is nine years old, but macros are better, as you
   suggested, so patch applied to master.
   
   -- 
     Bruce Momjian  <bruce@momjian.us>        https://momjian.us
     EDB                                      https://enterprisedb.com
   
     Only you can decide what is important to you.