Horton

Re: Simplify if/else logic of walsender CreateReplicationSlot

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-11-20T08:07:38Z
Lists: pgsql-hackers 
On Mon, Nov 20, 2023 at 06:01:42PM +1100, Peter Smith wrote:
> While reviewing another patch I was looking at the walsender's static
> function CreateReplicationSlot
> 
> I found that the current logic seemed to have some unnecessary if/else
> checking which can be simplified.

Good idea.  What you are suggesting here improves the readability of
this code, so +1.
--
Michael

Commits

  1. Simplify some logic in CreateReplicationSlot()