Re: Remove MSVC scripts from the tree
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Andres Freund <andres@anarazel.de>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-11-20T08:03:28Z
Lists: pgsql-hackers
On Mon, Nov 20, 2023 at 08:00:09AM +0100, Peter Eisentraut wrote: > I had suggested this arrangement as a way to reduce churn in this patch set. > We'd just move over the existing separate chapter into a new section, and > then later consider further rearrangements. > > It's not always clear where all of these things should go, as there are so > many dimensions. For example, the existing sentence "After you have > everything installed, it is suggested that you run psql under CMD.EXE, as > the MSYS console has buffering issues.", does that apply to MinGW, or really > MSYS, or does it also apply if you build with Visual Something? Even for this specific one, are you sure that it still applies? :D > Ultimately, I don't think MinGW needs to be its own section. Yes, agreed. The end result should be one single sect2 for Windows divided into multiple sect3, perhaps themselves divided into more sect4 for each build method. As a whole, before refactoring all that, I'd be in favor of a slightly different strategy once the MSVC scripts and install-windows.sgml with its stuff specific to src/tools/msvc are gone: - Review all this section from the docs and trim them from everything that we think is now irrelevant. - Look at the rest and see how it can be efficiently refactored into balanced sections. Your suggestion to create a new sect2 for "Windows" as much as Andres' suggestion are OK by as an intermediate step, and I suspect that the end result will likely not be that. -- Michael
Commits
-
Make win32tzlist.pl checkable again
- 8ddf9c1dc020 17.0 landed
-
meson: Make gzip and tar optional
- 9ca6e7b9411e 17.0 landed
-
meson: Make sed optional
- 9aa374dcfb76 17.0 landed
-
Remove MSVC scripts
- 1301c80b2167 17.0 landed
-
Replace Gen_dummy_probes.sed with Gen_dummy_probes.pl
- 3849fe7c2ba7 17.0 landed