Horton

Re: pg_upgrade and logical replication

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: vignesh C <vignesh21@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Amit Kapila <amit.kapila16@gmail.com>
Date: 2023-11-19T23:56:58Z
Lists: pgsql-hackers 
On Sun, Nov 19, 2023 at 06:56:05AM +0530, vignesh C wrote:
> On Sun, 19 Nov 2023 at 06:52, vignesh C <vignesh21@gmail.com> wrote:
>> On Fri, 10 Nov 2023 at 19:26, vignesh C <vignesh21@gmail.com> wrote:
>>> I will analyze more on this and post the analysis in the subsequent mail.
>>
>> I analyzed further and felt that retaining subscription oid would be
>> cleaner as subscription/subscription_rel/replication_origin/replication_origin_status
>> all of these will be using the same oid as earlier and also probably
>> help in supporting upgrade of subscription in more scenarios later.
>> Here is a patch to handle the same.
> 
> Sorry I had attached the older patch, here is the correct updated one.

Thanks for digging into that.  I think that we should consider that
once the main patch is merged and stable in the tree for v17 to get a
more consistent experience.  Shouldn't this include a test in the new
TAP test for the upgrade of subscriptions?  It should be as simple as
cross-checking the OIDs of the subscriptions before and after the
upgrade.
--
Michael

Commits

  1. pg_upgrade: Retrieve subscription count more efficiently.

  2. Fix random failure in 004_subscription.

  3. Fix 004_subscription.pl to allow its usage in --link mode.

  4. Allow upgrades to preserve the full subscription's state.

  5. Prevent startup of logical replication launcher during pg_upgrade