Horton

Re: Add new option 'all' to pg_stat_reset_shared()

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: torikoshia <torikoshia@oss.nttdata.com>
Cc: Andres Freund <andres@anarazel.de>, boekewurm+postgres@gmail.com, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@postgresql.org, bharath.rupireddyforpostgres@gmail.com
Date: 2023-11-15T00:47:03Z
Lists: pgsql-hackers 
On Tue, Nov 14, 2023 at 10:02:32PM +0900, torikoshia wrote:
> Attached patch.

You have forgotten to update the errhint at the end of
pg_stat_reset_shared(), where "slru" needs to be listed :)

> BTW currently the documentation explains all the arguments of
> pg_stat_reset_shared() in one line and I feel it's a bit hard to read.
> Attached patch uses <itemizedlist>.

Yes, this one is a good idea because each target works on a different
system view so it becomes easier to understand what a target affects,
so I've applied this bit, without the slru addition.
--
Michael

Commits

  1. Add target "slru" to pg_stat_reset_shared()

  2. doc: Improve description of targets for pg_stat_reset_shared()

  3. Add support for pg_stat_reset_slru without argument

  4. Add ability to reset all shared stats types in pg_stat_reset_shared()