Horton

Re: Typo with amtype = 's' in opr_sanity.sql

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-11-22T00:34:24Z
Lists: pgsql-hackers 
On Tue, Nov 21, 2023 at 01:02:40PM +0300, Aleksander Alekseev wrote:
>> It seems to me that this has been copy-pasted on HEAD from the
>> sequence AM patch, but forgot to update amtype to 't'.  While that's
>> maybe cosmetic, I think that this could lead to unexpected results, so
>> perhaps there is a point in doing a backpatch?
> 
> I disagree that it's cosmetic. The test doesn't check what it's supposed to.

Yes, I've backpatched that all the way down to 12 at the end.
--
Michael

Commits

  1. Fix query checking consistency of table amhandlers in opr_sanity.sql