Re: Remove MSVC scripts from the tree

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-11-08T23:05:20Z
Lists: pgsql-hackers
On Wed, Nov 08, 2023 at 09:41:19AM +0100, Peter Eisentraut wrote:
> I don't think we should rely on sed being there on Windows.  Maybe it's true
> now on the handful of buildfarm/CI machines and early adopters, but do we
> have any indication that that is systematic or just an accident?

Or both?  When doing builds based on MinGW in the past I vaguely
recall getting annoyed that I needed to look for sed as one thing, so
your suggestion could simplify the experience a bit.

> Since we definitely require Perl now, we could just as well use the Perl
> script and avoid this issue.
>
> Attached is a Perl version of the sed script, converted by hand (so not the
> super-verbose s2p thing).  It's basically just the sed script with
> semicolons added and the backslashes in the regular expressions moved
> around.  I think we could use something like that for all platforms now.

Sounds like a good idea to me now that perl is a hard requirement.
+1.
--
Michael

Commits

  1. Make win32tzlist.pl checkable again

  2. meson: Make gzip and tar optional

  3. meson: Make sed optional

  4. Remove MSVC scripts

  5. Replace Gen_dummy_probes.sed with Gen_dummy_probes.pl