Re: Show version of OpenSSL in ./configure output
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-10-23T23:33:30Z
Lists: pgsql-hackers
Attachments
- openssl-configure-v2.patch (text/x-diff) patch v2
On Mon, Oct 23, 2023 at 06:06:02PM +0200, Peter Eisentraut wrote: > On 23.10.23 16:26, Tom Lane wrote: >> Also, since "PGAC_PATH_PROGS(OPENSSL, openssl)" prints the full path to >> what it found, you can at least tell after the fact that you are being >> misled, because you can cross-check that path against the -L switches >> being used for libraries. > > Yeah, that seems ok. FWIW, I was also contemplating this one yesterday: +PKG_CHECK_MODULES(OPENSSL, openssl) Still, when I link my builds to a custom OpenSSL one, I force PATH to point to a command of openssl related to the libs used so PGAC_PATH_PROGS is more useful. I guess that everybody here does the same. It could be of course possible to show both the command from PATH and from pkg-config, but that's just confusing IMO. There may be a point in doing the same for other commands like LZ4 and Zstandard but these have been less of a pain in the buildfarm, even if we don't use them for that long, so I cannot get excited about spending more ./configure cycles for these. Please find attached a patch to move the version call close to the existing PGAC_PATH_PROGS. And of course, I'd like to do a backpatch. Is that OK? -- Michael
Commits
-
Log OpenSSL version in ./configure output
- f76f1ef00d3e 16.1 landed
- 55a428a18d03 17.0 landed