Horton

Re: Add support for AT LOCAL

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>, Noah Misch <noah@leadboat.com>, Vik Fearing <vik@postgresfriends.org>, cary huang <hcary328@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2023-10-16T04:22:54Z
Lists: pgsql-hackers 
On Sun, Oct 15, 2023 at 11:30:17PM -0400, Tom Lane wrote:
> Thomas Munro <thomas.munro@gmail.com> writes:
>> If that can be shown I would vote for switching to /opt/IBM/xlc/16.1.0
>> and not changing a single bit of PostgreSQL.
> 
> If switching to 16.1 removes the failure, I'd agree.  It's hard
> to believe that any significant number of users still care about
> building PG with xlc 12.

FWIW, I really wish that we were less conservative here and just drop
that rather than waste resources in debugging things.

Now, I'm also OK to put this one aside and put a WHERE clause to
timetz_local_view to only fetch one value, as the test has the same
value as long as we check that AT LOCAL converts the result to UTC for
the three expression patterns tested.
--
Michael

Commits

  1. Dodge a compiler bug affecting timetz_zone/timetz_izone.

  2. Back-patch test cases for timetz_zone/timetz_izone.

  3. Add regression test coverage for timetz_izone().

  4. Add support for AT LOCAL

  5. doc: Mention timezone(zone, time) in section for AT TIME ZONE

  6. Use HASH_BLOBS for xidhash.