Re: Move global variables of pgoutput to plugin private scope.

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-09-27T05:47:22Z
Lists: pgsql-hackers
On Wed, Sep 27, 2023 at 04:51:29AM +0000, Zhijie Hou (Fujitsu) wrote:
> While searching the code, I noticed one postgres fork where the PGoutputData is
> used in other places, although it's a separate fork, but it seems better to
> discuss the removal separately.
> 
> [1] https://github.com/Tencent/TBase/blob/7cf7f8afbcab7290538ad5e65893561710be3dfa/src/backend/replication/walsender.c#L100

Indeed.  Interesting.
--
Michael

Commits

  1. Move tracking of in_streaming to PGOutputData

  2. Fix the misuse of origin filter across multiple pg_logical_slot_get_changes() calls.

  3. Fix typos in pgoutput.c